ui.column_selection: the error message is lost, and select_view can return None #22

Open
opened 2026-10-06 13:48:09 +00:00 by ffrauenberger · 0 comments
Owner

Severity: low (the user does not see why the column selection failed)

Where

  • app/ui/column_selection_ui/column_selection_controller.py:59-92

Problem

  • When no DataFrame exists, the controller stores the message in an instance attribute (self.error_message = "Please upload a file first") and then calls to_home(); st.rerun(). The instance is discarded on rerun, so the message is never shown.
  • select_view has a pass branch for self.selected_algorithm == "" and returns None there. BaseController.start would then fail on tuple unpacking. The branch is unreachable today, but it is a trap for future changes.

Steps to reproduce

  1. Navigate to the Column Selection page without having uploaded a file (e.g. after a session reset)

Expected behavior

The user is redirected home and sees "Please upload a file first".

Actual behavior

The user is redirected home without any message.

Fix

Write the message to st.session_state.error before calling to_home() (which preserves error). Remove or fix the pass branch in select_view.


from issues/BUG-022-column-selection-error-message-lost-and-select-view-returns-none.md (code analysis of commit 6bcc646, 2026-10-03)

**Severity:** low (the user does not see why the column selection failed) ## Where - `app/ui/column_selection_ui/column_selection_controller.py:59-92` ## Problem - When no DataFrame exists, the controller stores the message in an **instance** attribute (`self.error_message = "Please upload a file first"`) and then calls `to_home(); st.rerun()`. The instance is discarded on rerun, so the message is never shown. - `select_view` has a `pass` branch for `self.selected_algorithm == ""` and returns `None` there. `BaseController.start` would then fail on tuple unpacking. The branch is unreachable today, but it is a trap for future changes. ### Steps to reproduce 1. Navigate to the Column Selection page without having uploaded a file (e.g. after a session reset) ### Expected behavior The user is redirected home and sees *"Please upload a file first"*. ### Actual behavior The user is redirected home without any message. ## Fix Write the message to `st.session_state.error` before calling `to_home()` (which preserves `error`). Remove or fix the `pass` branch in `select_view`. --- from `issues/BUG-022-column-selection-error-message-lost-and-select-view-returns-none.md` (code analysis of commit 6bcc646, 2026-10-03)
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ffrauenberger/ProcessIntel#22
No description provided.