forked from SWISDATA/processintel
mining: introduce a declarative miner parameter contract and a generic controller #48
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#48
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (medium)
Where
app/mining_algorithms/mining_interface.pygenerate_graphsignaturesapp/ui/*_miner_ui/*_controller.pyand*_view.pyProblem
MiningInterfacedoes not declaregenerate_graph, its parameters or its getters. Every miner has its own positional signature, and controllers rely on matching keyword names (dependency_threshold,edge_freq_threshold_normalized, …). A typo only shows up at runtime as aTypeError.process_algorithm_parameters,have_parameters_changed,get_sidebar_values, the view widget,perform_miningand a model getter. Genetic and Fuzzy repeat this for 7–8 parameters each, and inconsistencies already exist (fitness_thresholdhas no getter and is read as an attribute;noise_thresholdis read viagetattr(..., 0.2)).threshold,edge_freq_threshold_normalized). This only works because navigation clears the whole session state.Fix
generate_graph(params: dict)methodfrom
issues/ARCH-003-no-explicit-miner-contract-and-duplicated-controller-boilerplate.md(code analysis of commit6bcc646, 2026-10-03)