forked from SWISDATA/processintel
converters.dfg: the fuzzy graph converter calls private miner methods via name mangling #50
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#50
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (medium)
Where
app/converters/dfg_converter.py:119-185app/mining_algorithms/fuzzy_mining.py:150-156,:330-382,:659-681,:789-811Problem
DFGConverter.build_fuzzy_graphreceives the miner object and does:The converter depends on Python name mangling of private methods, and the miner's helpers mutate
self.graphandself.cluster_id_mappingas side effects. Renaming the class or a method breaks this silently, and the converter abstraction (separating mining from visualization) does not hold for the fuzzy miner. The other converters receive data objects (HeuristicDFGData,AlphaPetriNetData).Fix
The fuzzy miner produces a plain result structure (nodes, clusters, edges with metrics), like the heuristic miner, and the converter builds the graph only from that.
from
issues/ARCH-005-converters-reach-into-private-miner-internals.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The abstraction and private-name coupling findings are confirmed. Correct “renaming the class or a method breaks this silently”:
getattr(miner, '_FuzzyMining__...')has no default, so a missing mangled method raisesAttributeErrorimmediately. The non-genetic base controller only catches graph exceptions, so this would normally surface as an exception page. The existing side effects and eager publication ofminer.graphare separate real concerns. Producing a plain fuzzy result structure remains a sound refactoring direction.Code references: app/converters/dfg_converter.py:124.