forked from SWISDATA/processintel
components.interactive_graph: build the frontend reproducibly and update its toolchain #55
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#55
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (low)
Where
app/components/interactiveGraph/frontend/build/**app/components/interactiveGraph/frontend/package.jsonpackage.nix.gitignore:17-18Problem
build/static/js/main.ee95aed2.js+ map,graphviz.umd.js,bootstrap.min.css) is checked in, and Nix packaging uses it as is. Nothing checks thatbuild/matchessrc/, so the bundle can silently differ from the reviewed source, and a source-only change has no effect.react-scripts5, deprecated) with React 16 and TypeScript 4.2, and gets no security updates.graphviz.umd.jsandbootstrap.min.cssare vendored twice (public/andbuild/).index.htmlloads Bootstrap, but the component uses no Bootstrap classes.graphviz(".graph")), so only one interactive graph can exist per page.Fix
buildNpmPackage) frompackage-lock.jsonand stop committingbuild/(or at least verify in CI that it matches the source)reffrom
issues/ARCH-010-committed-frontend-build-and-outdated-toolchain.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The build/packaging and aging toolchain concerns are supported. The
.graphselector does not establish that only one interactive graph can exist on a Streamlit page: this usesstreamlit.components.v1.declare_component, whose instances run in separate iframes. It would conflict with multiple React graph instances within one iframe/document; separate Streamlit component instances are isolated. See Streamlit's v1 component documentation.Also, deprecated CRA does not by itself prove that the whole dependency tree “gets no security updates”; React describes CRA as continuing in maintenance mode. Pin that assertion to an actual dependency/advisory if needed. The shipped source map's
InteractiveGraph.tsxcurrently matchessrc/InteractiveGraph.tsx; the missing CI guarantee remains a valid finding.Code references: app/components/interactiveGraph/init.py:20, app/components/interactiveGraph/frontend/src/InteractiveGraph.tsx:87.