workflows: close gaps in the CI workflows #58

Open
opened 2026-10-06 13:54:31 +00:00 by ffrauenberger · 1 comment
Owner

Severity: improvement (low to medium)

Where

  • .github/workflows/build.yml
  • .forgejo/workflows/build.yml

Problem

  • Path filters only trigger on **/*.py, package.nix, flake.* and the workflow file. Changes to pyproject.toml, requirements*.txt, module.nix, app/.streamlit/config.toml, docs/algorithms/*.md (shipped and rendered by the app) or the frontend do not run the build.
  • Black checks only changed files, so formatting drift elsewhere is never caught. After a force-push the old before commit may be missing from the clone, so the diff fails and Black is skipped.
  • On the first push of a new branch, github.event.before is 0000000…; git diff fails, the pipe hides the error and Black is skipped.
  • Tests only run inside nix build. There is no plain pip install -r requirements.txt && unittest job, so the README installation path (used by most contributors) is never verified.
  • There is no test for module.nix (e.g. a NixOS VM test), which is how #60 went unnoticed.
  • The GitHub and Forgejo workflows are near-duplicates and have already diverged (diff range computation).

Related: #60.

Fix

  • Drop or widen the path filters
  • Run black --check . on the whole repository
  • Add a pip-based test job
  • Add nixosTests-style checks for the service module
  • Share or align the GitHub and Forgejo workflow definitions

from issues/TEST-003-ci-workflow-gaps.md (code analysis of commit 6bcc646, 2026-10-03)

**Severity:** improvement (low to medium) ## Where - `.github/workflows/build.yml` - `.forgejo/workflows/build.yml` ## Problem - **Path filters** only trigger on `**/*.py`, `package.nix`, `flake.*` and the workflow file. Changes to `pyproject.toml`, `requirements*.txt`, `module.nix`, `app/.streamlit/config.toml`, `docs/algorithms/*.md` (shipped and rendered by the app) or the frontend do not run the build. - **Black** checks only changed files, so formatting drift elsewhere is never caught. After a force-push the old `before` commit may be missing from the clone, so the diff fails and Black is skipped. - On the first push of a new branch, `github.event.before` is `0000000…`; `git diff` fails, the pipe hides the error and Black is skipped. - Tests only run inside `nix build`. There is no plain `pip install -r requirements.txt && unittest` job, so the README installation path (used by most contributors) is never verified. - There is no test for `module.nix` (e.g. a NixOS VM test), which is how #60 went unnoticed. - The GitHub and Forgejo workflows are near-duplicates and have already diverged (diff range computation). Related: #60. ## Fix - Drop or widen the path filters - Run `black --check .` on the whole repository - Add a pip-based test job - Add `nixosTests`-style checks for the service module - Share or align the GitHub and Forgejo workflow definitions --- from `issues/TEST-003-ci-workflow-gaps.md` (code analysis of commit 6bcc646, 2026-10-03)
Author
Owner

Reviewed by Codex (GPT-6) against origin/main 6bcc646eb464.

Review: partially correct.

The path filters, narrow formatting checks and missing pip/module jobs are supported. The “first push of a new branch” example needs a condition: both push triggers are restricted to branches: [main], so an ordinary first push of a feature branch does not run these workflows at all. The zero-before diff failure applies if the triggered main ref is newly created, or in another configuration that permits new-branch pushes. Keep the force-push/missing-object failure and masked diff errors as the general issue.

Code references: .github/workflows/build.yml:4, .forgejo/workflows/build.yml:4.

Reviewed by **Codex (GPT-6)** against origin/main [`6bcc646eb464`](https://code.swisdata.eu/ffrauenberger/ProcessIntel/commit/6bcc646eb464e0dd897228b5e49867f65d7255c4). **Review: partially correct.** The path filters, narrow formatting checks and missing pip/module jobs are supported. The “first push of a new branch” example needs a condition: both push triggers are restricted to `branches: [main]`, so an ordinary first push of a feature branch does not run these workflows at all. The zero-`before` diff failure applies if the triggered `main` ref is newly created, or in another configuration that permits new-branch pushes. Keep the force-push/missing-object failure and masked diff errors as the general issue. Code references: [.github/workflows/build.yml:4](https://code.swisdata.eu/ffrauenberger/ProcessIntel/src/commit/6bcc646eb464e0dd897228b5e49867f65d7255c4/.github/workflows/build.yml#L4), [.forgejo/workflows/build.yml:4](https://code.swisdata.eu/ffrauenberger/ProcessIntel/src/commit/6bcc646eb464e0dd897228b5e49867f65d7255c4/.forgejo/workflows/build.yml#L4).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ffrauenberger/ProcessIntel#58
No description provided.