forked from SWISDATA/processintel
workflows: close gaps in the CI workflows #58
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#58
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (low to medium)
Where
.github/workflows/build.yml.forgejo/workflows/build.ymlProblem
**/*.py,package.nix,flake.*and the workflow file. Changes topyproject.toml,requirements*.txt,module.nix,app/.streamlit/config.toml,docs/algorithms/*.md(shipped and rendered by the app) or the frontend do not run the build.beforecommit may be missing from the clone, so the diff fails and Black is skipped.github.event.beforeis0000000…;git difffails, the pipe hides the error and Black is skipped.nix build. There is no plainpip install -r requirements.txt && unittestjob, so the README installation path (used by most contributors) is never verified.module.nix(e.g. a NixOS VM test), which is how #60 went unnoticed.Related: #60.
Fix
black --check .on the whole repositorynixosTests-style checks for the service modulefrom
issues/TEST-003-ci-workflow-gaps.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The path filters, narrow formatting checks and missing pip/module jobs are supported. The “first push of a new branch” example needs a condition: both push triggers are restricted to
branches: [main], so an ordinary first push of a feature branch does not run these workflows at all. The zero-beforediff failure applies if the triggeredmainref is newly created, or in another configuration that permits new-branch pushes. Keep the force-push/missing-object failure and masked diff errors as the general issue.Code references: .github/workflows/build.yml:4, .forgejo/workflows/build.yml:4.