forked from SWISDATA/processintel
docs: README, version metadata and UI text disagree with the code #62
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#62
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (low)
Where
README.mdpyproject.toml:7package.nix:44app/ui/home_ui/home_view.py:49-60,:91Problem
.pickleis not an accepted upload type (and should not become one, see #32).1.0.0,pyproject.toml1.0,package.nixv1: three different strings for one release.Related: #32, #56.
Fix
importlib.metadata.version("processintel"), Nixversionread frompyproject.toml)from
issues/DOC-001-readme-and-metadata-inconsistent-with-code.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The README input/algorithm/import discrepancies are supported. Two details need qualification. The
Mining Algorthmtypo is indisplay_model_import()(home_view.py:79–98), called only by the currently unreachable pickle-import branch, so it is not a label users encounter in the present CSV/XES home flow. It is still a code typo worth fixing.Also,
1.0and1.0.0are equivalent Python release-version spellings, so differing strings alone do not establish differing releases. Nix'sv1is a separate presentation string. Single-sourcing version metadata remains useful; avoid implying three incompatible release versions merely from these spellings.Code references: app/ui/home_ui/home_view.py:79, app/ui/home_ui/home_controller.py:93, pyproject.toml:7.