forked from SWISDATA/processintel
app: clean up dead code, leftovers and naming issues #63
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#63
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (low)
Where
app/analysis/detection_model.py:87app/components/interactiveGraph/frontend/src/InteractiveGraph.tsx:44app/config.py:22-23app/mining_algorithms/alpha_mining.py:224-234,:262-269app/mining_algorithms/base_mining.py:652app/mining_algorithms/fuzzy_mining.py:70,:646-651,:877-881app/mining_algorithms/inductive_mining.py:87-89app/transformations/dataframe_styler.py:49app/ui/column_selection_ui/base_column_selection_view.py:99app/ui/fuzzy_miner_ui/fuzzy_miner_view.py:8app/ui/home_ui/home_view.py:393-410templates/Problem
app/mining_algorithms/inductive_mining.py:87-89events_to_removeis computed (O(n)) and only logged, never used.app/mining_algorithms/alpha_mining.py:224-234create_safe_ingoing_edge/create_safe_outgoing_edge/create_safe_nodeare unused and calladd_empty_circle, which does not exist onPetriNetGraph.app/mining_algorithms/alpha_mining.py:262-269__is_set_in_parallelis unused.app/mining_algorithms/fuzzy_mining.py:646-651__get_clustered_nodeis unused.app/mining_algorithms/fuzzy_mining.py:70,:144,:209-210,:720,:809,:819,:825printleftovers; comments like# why is this done?and "asked ChatGpt how to do this" in docstrings.app/mining_algorithms/fuzzy_mining.py:877-881dictshadows the builtin;sumis shadowed at line 709. Significance values are stored as strings (format(..., ".2f")) and parsed back later.app/transformations/dataframe_styler.py:49stlye_df.app/config.py:22-23and many usagescluster_seperator(typo).app/ui/fuzzy_miner_ui/fuzzy_miner_view.py:8app/ui/home_ui/home_view.py:393-410_default_indexis documented as returningNoneand taking "a list of preferred values", but returns0and takes a single value.app/ui/column_selection_ui/base_column_selection_view.py:99algorithm = st.selectbox(...)is assigned and never used.app/analysis/detection_model.py:87f"Delimiter detection failed"is an f-string without placeholders; the exceptioneis discarded.app/components/interactiveGraph/frontend/src/InteractiveGraph.tsx:44console.log(node_id)left in production code.app/mining_algorithms/base_mining.py:652templates/Fix
Remove the dead code and leftovers, fix the typos and wrong docstrings, and add the templates to CI (at least an import/instantiation check).
from
issues/CQ-001-dead-code-and-leftovers.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The cleanup findings are largely supported. Correct the Alpha helper row: only
create_safe_nodecalls the nonexistentPetriNetGraph.add_empty_circle;create_safe_ingoing_edgeandcreate_safe_outgoing_edgecallcreate_edgeinstead (lines 224–234). All three are currently unused in the application/test/template searches. Also,_default_indexdocuments anint | Nonereturn, withNonefor the no-match case; the mismatch is specifically that the no-match implementation returns 0, not that the entire function is documented as always returning None.Code references: app/mining_algorithms/alpha_mining.py:224, app/ui/home_ui/home_view.py:393.