forked from SWISDATA/processintel
components.interactive_graph: clicking an edge crashes for activity names containing -> #25
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#25
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: low (only names containing
->are affected)Where
app/components/interactiveGraph/frontend/src/InteractiveGraph.tsx:51-60app/components/interactiveGraph/__init__.py:48-52Problem
The frontend takes source and target from the SVG
<title>text and doestitleText.split("->"). For an activity named e.g.Step 1 -> 2this produces more than two parts and the wrong source/target. On the Python side,graph.edge_to_stringthen raisesEdgeDoesNotExistException, which is not caught ininteractiveGraph.Steps to reproduce
Step 1 -> 2Expected behavior
The edge details are shown.
Actual behavior
A Streamlit exception page (
EdgeDoesNotExistException).Related: #51.
Fix
Give each edge an explicit
idattribute in DOT (e.g. an index), send that ID back and look the edge up by ID. Catch lookup errors ininteractiveGraph.from
issues/BUG-025-edge-click-parsing-breaks-on-arrow-in-names.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The frontend
split('->')ambiguity and missing Python lookup-error handling are real. The written end-to-end reproduction is currently blocked by #2: an activity namedStep 1 -> 2places an unescaped>in its HTML-like label. Directly rendering that node with the revieweddotraisesCalledProcessError, before a clickable graph appears. State the prerequisite that labels are escaped first, or test the click parser with a valid DOT graph using an escaped/custom label and the raw activity ID. Then the ambiguous SVG title demonstrates this separate bug.Code references: app/components/interactiveGraph/frontend/src/InteractiveGraph.tsx:53, app/graphs/visualization/directly_follows_graph.py:36.