forked from SWISDATA/processintel
graphs: separate internal node IDs from display labels #51
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#51
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (medium: the triggers can each be fixed with small changes first; the full refactor is large)
Where
app/graphs/visualization/base_graph.py(add_node,substitute_colons,get_node,get_edge)app/config.py:19-20app/ui/base_algorithm_ui/base_algorithm_controller.py:242-253app/converters/(not the CSV/XES converters)app/ui/genetic_miner_ui/genetic_miner_controller.py:171-180— secondInvalidNodeNameExceptionhandlerapp/graphs/visualization/bpmn_graph.py:339,app/graphs/visualization/petri_net_graph.py:142-146— node kind guessed from the IDapp/graphs/petri_net.py,app/mining_algorithms/fuzzy_mining.py,app/components/interactiveGraph/frontend/src/InteractiveGraph.tsx:53-54Problem
Graph node IDs are the raw activity names. Several problems follow from this single decision:
:has a meaning in DOT edge statements (node:port), so colons are replaced by___. Activity names that contain___are rejected withInvalidNodeNameException, and the user is sent home with an error.Start,End,tau,p_start, gate and silent prefixes) collide with real activities (#7, #19)._get_escaped_node_id).Corrections from the review
bpmn_graph.py:339):Investigate,Delegate,Navigateall match.taucollision. The inductive miners use the string"tau"as the silent marker in the process tree (inductive_mining.py:177,246,250;inductive_mining_infrequent.py:121,174,181,245). The tree needs a sentinel object as well."Cluster <n>"(fuzzy_mining.py:794) also collide with activities: an activityCluster 1raisesDuplicateNodeException.{"Start", "End"}in the fuzzy start/end detection (dfg_converter.py:157-183) has to move to node kinds too.None.Root cause of #2, #7, #19, #25.
Related to upstream GitHub issue SWISDATA/processintel#31 Decouple Base Graph and Graphviz Representation.
Fix
n17); the activity name is kept only inlabel/ node dataFixing this resolves #2, #19 and #25, and most of #7 (with the
tausentinel below).Constraints from the review
base_algorithm_controller.py:323-326,:367-370). A per-build counter would make every node look new. Derive IDs from a logical key, e.g.("activity", name), through a per-graph registry, or match by the logical key.base_graph.py:232-244). It needs a lookup by activity.activity,gate,silent,place,start,end,cluster) onNodeinstead of guessing it from the ID.tausentinel in the process tree.petri_net.py:46-47,113-118). It needs separate namespaces, oradd_petri_net_to_graphmust map(kind, id)to graph IDs.<title>on->.colon_substitute,substitute_colons*, bothInvalidNodeNameExceptionhandlers and the colon tests (tests/graphs/visualization/base_graph_test.py:212-250).The realistic triggers can be fixed first and on their own: HTML escaping (#2) and Start/End collisions (#7).
from
issues/ARCH-006-node-identity-equals-display-label.md(code analysis of commit6bcc646, 2026-10-03), corrected by the review inverdicts-claude/ARCH-006-node-identity-equals-display-label.md