forked from SWISDATA/processintel
graphs: activities named Start, End or tau collide with reserved node IDs #7
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#7
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: critical (logs with activities called Start or End cannot be mined)
Where
app/graphs/visualization/base_graph.py:345-363app/converters/dfg_converter.py:45-62app/converters/petri_net_converter.pyapp/graphs/visualization/bpmn_graph.py:114-128,:268-321app/mining_algorithms/inductive_mining.py:176-179,:246-250Problem
Graph node IDs are the activity names themselves, and the code reserves several IDs in the same namespace:
Start,Endadd_start_node/add_end_node)taup_start,p_end,pi_<act>…,po_<act>…,tau_<n>exclusive_gate_start_<n>,parallel_gate_*,silent_activity_<n>Many real logs have explicit activities called
StartandEnd.Steps to reproduce
StartandEnd(ortau)Expected behavior
The activities
Start,Endandtauare shown as normal activities, separate from the artificial start/end nodes and silent steps.Actual behavior
Start/End:add_event("Start")oradd_start_node()raisesDuplicateNodeException. The controller shows "Do not change the parameters while mining" and no graph is produced.tau: the activity is treated as a silent step and disappears from the model.-, so{"a-b"}and{"a","b"}get the same ID and are merged.Related: #51 (root cause).
Fix
Separate internal IDs from display labels: use generated IDs (
n0,n1, …) or a reserved, escaped prefix (__start__), and keep the activity name only in the label and node data. See #51.from
issues/BUG-007-reserved-node-ids-collide-with-activity-names.md(code analysis of commit6bcc646, 2026-10-03)gate,silentortau#19Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
Start/End collisions and the inductive
tausentinel collision are supported. Two details need correction. First,tauis treated as silent by the Inductive/IMf process-tree paths, not by every miner. Second, joining{a-b}and{a,b}does not by itself merge their genetic places: IDs include the activity and subset index, e.g.pi_<act>_<idx>_<members>andpo_<act>_<idx>_<members>(lines 379/428). Different subsets of one activity have different indexes. The broader shared-ID namespace risk remains, but this exact example does not establish it. A replacement prefix must also be made disjoint from accepted activity IDs; simply choosing another user-enterable string moves the collision.Code references: app/converters/petri_net_converter.py:379, app/converters/petri_net_converter.py:428, app/converters/petri_net_converter.py:91.