forked from SWISDATA/processintel
tests: add tests for Alpha, Fuzzy, Petri net conversion and UI flows #57
Labels
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ffrauenberger/ProcessIntel#57
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: improvement (medium: the untested paths hold several of the bugs found)
Where
app/mining_algorithms/alpha_mining.py— no testsapp/mining_algorithms/fuzzy_mining.py— no testsapp/converters/petri_net_converter.py,app/graphs/petri_net.py— no conversion or token-game testsapp/converters/dfg_converter.py— no testsapp/graphs/visualization/— no label-escaping testsapp/ui/— no controller or view testsProblem
There are no tests for:
mining_algorithms/alpha_mining.pymining_algorithms/fuzzy_mining.pyconverters/petri_net_converter.py,graphs/petri_net.pygenetic_mining_test.pyexercisessimulate_traceonly indirectly and asserts only the graph type; the process-tree → Petri-net conversion used by Inductive/IMf is never tested)converters/dfg_converter.pygraphs/visualization/*transformations,io_operationsapp/ui/**threshold_bug_test.pyandthreshold_filtering_test.pyexist, but no test exercises_sync_thresholdstogether with the SPM filter (#11).Overlaps with upstream GitHub issue SWISDATA/processintel#3 Improve and Extend Test Coverage for Process Mining Algorithms.
Fix
tests/testcsvsimulate_trace(it rejects valid traces, see #4)Start,End,R&D,a<b,x:y,Pay/Pay Invoice,tau) that run through every miner and render withdotAppTest(streamlit.testing.v1) tests for the flow Home → Column Selection → Algorithm → Exportfrom
issues/TEST-002-missing-test-coverage-for-critical-paths.md(code analysis of commit6bcc646, 2026-10-03)Reviewed by Codex (GPT-6) against origin/main
6bcc646eb464.Review: partially correct.
The Alpha/Fuzzy/controller and inductive process-tree conversion gaps are supported, but the token-game coverage statement is incorrect.
genetic_mining_test.pyhas dedicated token-game tests for completion, deadlocks, filtered traces, length-one and length-two loops, and further branching examples. They assert parsed counts and completion/deadlock outcomes, not merely the graph type. I ran four focused token-game tests successfully, alongside the six transformation tests.The accurate gap is absence of independent strict reachability/soundness tests for
build_inductive_graph()and its XOR conversion, plus possible limitations in using the existing replay implementation as its own oracle. Do not describe the repository as having no token-game tests.Code references: tests/mining_algorithms/genetic_mining_test.py:103, tests/mining_algorithms/genetic_mining_test.py:171, tests/mining_algorithms/genetic_mining_test.py:322.